-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalizer fix #951
Finalizer fix #951
Conversation
Dropped outdated sdk build dependencies
src/Lucene.Net/Lucene.Net.csproj
Outdated
<InternalsVisibleTo Include="Lucene.Net.Tests.TestFramework" /> | ||
<InternalsVisibleTo Include="Lucene.Net.Tests.TestFramework.DependencyInjection" /> | ||
</ItemGroup> | ||
<Import Project="$(SolutionDir).build/nuget.props" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO formatting should be done in a separate PR. But that said, we should have correct indentation settings for more file types in .editorconfig and default settings for unspecified files. 2 spaces for XML/JSON type files seems to be the standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and your willingness to help make our project better.
There are a few changes we would like you to make before we can accept this PR. Please see the comments inline.
src/dotnet/Lucene.Net.Tests.CodeAnalysis/Lucene.Net.Tests.CodeAnalysis.csproj
Outdated
Show resolved
Hide resolved
…CodeAnalysis to publish tests for net8.0
Summary of the changes (Less than 80 chars)
Fixes #950
Description
Dropped the finalizer in IndexReader