Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.build/runbuild.ps1: Changed to edit the global.json file instead of overwriting it to account for any future changes to it. #991

Merged

Conversation

NightOwl888
Copy link
Contributor

@NightOwl888 NightOwl888 commented Oct 23, 2024

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

.build/runbuild.ps1: Changed to edit the global.json file instead of overwriting it to account for any future changes to it.

This fixes the Azure DevOps and command line build, which was inadvertently broken by #987.

…overwriting it to account for any future changes to it.
@NightOwl888 NightOwl888 merged commit 31ba5d1 into apache:master Oct 23, 2024
@@ -67,7 +67,7 @@ task Clean -description "This task cleans up the build directory" {

task UpdateLocalSDKVersion -description "Backs up the project.json file and pins the version to $minimumSdkVersion" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but the description refers to the "project.json" file when I think it should be "global.json"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Leftovers from the dnx days, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants