-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8583] Missing SISU bean definitions from maven-resolver-provider #2110
base: master
Are you sure you want to change the base?
Conversation
Any chance the OOM is related?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the impact of this? If this is a bug, why did it not break any tests? Is a test missing?
It did not break any tests because it's not used anymore in the standard use cases. I saw it while testing https://github.com/smallrye/smallrye-beanbag which boots a custom resolver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, can we add a test that fails without this?
JIRA issue: MNG-8583
The beans are not recognized by Sisu as the needed META-INF file is missing.