Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8583] Missing SISU bean definitions from maven-resolver-provider #2110

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 14, 2025

JIRA issue: MNG-8583

The beans are not recognized by Sisu as the needed META-INF file is missing.

@gnodet gnodet changed the title Missing SISU bean definitions from maven-resolver-provider [MNG-8583] Missing SISU bean definitions from maven-resolver-provider Feb 14, 2025
@gnodet gnodet added this to the 4.0.0-rc-3 milestone Feb 14, 2025
@gnodet gnodet requested a review from cstamas February 14, 2025 09:58
@elharo
Copy link
Contributor

elharo commented Feb 15, 2025

Any chance the OOM is related?

Error:  Java heap space -> [Help 1]
java.lang.OutOfMemoryError: Java heap space
    at org.apache.bcel.classfile.Constant.readConstant(Constant.java:86)
    at org.apache.bcel.classfile.ConstantPool.<init>(ConstantPool.java:89)
    at org.apache.bcel.classfile.ClassParser.readConstantPool(ClassParser.java:224)
    at org.apache.bcel.classfile.ClassParser.parse(ClassParser.java:132)
    at org.apache.maven.shared.jar.classes.JarClassesAnalysis.analyze(JarClassesAnalysis.java:185)
    at org.apache.maven.shared.jar.classes.JarClassesAnalysis.analyzeRoot(JarClassesAnalysis.java:165)
    at org.apache.maven.shared.jar.classes.JarClassesAnalysis.analyze(JarClassesAnalysis.java:114)
    at org.apache.maven.report.projectinfo.dependencies.Dependencies.getJarDependencyDetails(Dependencies.java:228)
    at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.hasSealed(DependenciesRenderer.java:1209)
    at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderSectionDependencyFileDetails(DependenciesRenderer.java:518)
    at org.apache.maven.report.projectinfo.dependencies.renderer.DependenciesRenderer.renderBody(DependenciesRenderer.java:233)
    at org.apache.maven.reporting.AbstractMavenReportRenderer.render(AbstractMavenReportRenderer.java:82)
    at org.apache.maven.report.projectinfo.DependenciesReport.executeReport(DependenciesReport.java:167)
    at org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:289)
    at org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:226)
    at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:348)
    at org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:194)
    at org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:143)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:146)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:339)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:179)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:168)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:165)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:110)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
    at org.apache.maven.lifecycle.internal.DefaultLifecycleStarter.execute(DefaultLifecycleStarter.java:123)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:311)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:225)

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the impact of this? If this is a bug, why did it not break any tests? Is a test missing?

@gnodet
Copy link
Contributor Author

gnodet commented Feb 15, 2025

What's the impact of this? If this is a bug, why did it not break any tests? Is a test missing?

It did not break any tests because it's not used anymore in the standard use cases. I saw it while testing https://github.com/smallrye/smallrye-beanbag which boots a custom resolver.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, can we add a test that fails without this?

@gnodet gnodet marked this pull request as draft February 17, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants