Skip to content

[MNG-8660] Decouple legacy prompter from implementation details #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

oehme
Copy link
Contributor

@oehme oehme commented Mar 27, 2025

JIRA issue: MNG-8660

The legacy prompter should only use the Prompter interface, not the DefaultPrompter implementaiton, so that the Maven daemon can override how prompting is implemented.

See apache/maven-mvnd#1303

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@oehme
Copy link
Contributor Author

oehme commented Mar 27, 2025

@gnodet this is one possible solution. The other would be to implement both the new and the legacy interfaces in the Maven daemon.

@gnodet
Copy link
Contributor

gnodet commented Mar 28, 2025

@oehme LGTM. Does that actually fixes the mvnd ITs ? I am slightly worried about a possible visibility issue for the beans.

@oehme
Copy link
Contributor Author

oehme commented Mar 28, 2025

Yep, when I build this branch locally and then upgrade the Daemon to it, the tests pass.

Should I create a jira issue for this?

@gnodet gnodet changed the title Decouple legacy prompter from implementation details [MNG-8660] Decouple legacy prompter from implementation details Mar 30, 2025
The legacy prompter should only use the Prompter interface, not the DefaultPrompter implementaiton,
so that the Maven daemon can override how prompting is implemented.

See apache/maven-mvnd#1303
@oehme oehme force-pushed the oehme/fix-legacy-prompter branch from 77847a2 to de036be Compare March 31, 2025 13:38
@oehme oehme marked this pull request as ready for review March 31, 2025 13:39
@gnodet gnodet added this to the 4.0.0-rc-4 milestone Apr 2, 2025
@gnodet gnodet merged commit 1c5dddd into apache:master Apr 3, 2025
13 checks passed
@oehme oehme deleted the oehme/fix-legacy-prompter branch April 4, 2025 15:08
@jira-importer
Copy link
Collaborator

Resolve #9357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants