[MNG-4559] Support spaces in jvm.config #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .mvn/jvm.config file parsing in mvn.cmd needed improvements to properly handle multiple JVM arguments, especially when dealing with comments, quotes and spaces in values. This PR: - Ensures proper parsing of multiple JVM arguments from .mvn/jvm.config - Maintains proper spacing between arguments - Handles both inline and full-line comments correctly - Fixes a bug in the space trimming logic (%%x -> %%i) - Preserves spaces within quoted values The changes are validated by MavenITmng4559MultipleJvmArgsTest which verifies: - Multiple JVM arguments are properly handled - Comments are correctly processed - Arguments with spaces in quotes are preserved - Arguments from multiple lines are properly combined Fixes: https://issues.apache.org/jira/browse/MNG-4559
elharo
approved these changes
Apr 1, 2025
gnodet
added a commit
that referenced
this pull request
Apr 3, 2025
…ts (#2213) The .mvn/jvm.config file parsing in mvn.cmd needed improvements to properly handle multiple JVM arguments, especially when dealing with comments, quotes and spaces in values. This PR: - Ensures proper parsing of multiple JVM arguments from .mvn/jvm.config - Maintains proper spacing between arguments - Handles both inline and full-line comments correctly - Fixes a bug in the space trimming logic (%%x -> %%i) - Preserves spaces within quoted values The changes are validated by MavenITmng4559MultipleJvmArgsTest which verifies: - Multiple JVM arguments are properly handled - Comments are correctly processed - Arguments with spaces in quotes are preserved - Arguments from multiple lines are properly combined Fixes: https://issues.apache.org/jira/browse/MNG-4559
|
Resolve #6145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: MNG-4559
The .mvn/jvm.config file parsing in mvn.cmd needed improvements to properly handle multiple JVM arguments, especially when dealing with comments, quotes and spaces in values.
This PR:
The changes are validated by MavenITmng4559MultipleJvmArgsTest which verifies: