-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[MNG-8637] Pull out Standalone API from UTs #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit moves the Standalone API implementation from the test directory to the main source directory, making it available for reuse outside of tests. The Standalone API provides a way to run Maven API in a standalone mode (without the full Maven environment), primarily for testing and specialized execution scenarios. This is now the proper way to utilize Maven 4 in MIMA-like scenarios. Key changes: - Moved ApiRunner and RepositorySystemSupplier from test to main source - Added UnsupportedInStandaloneModeException for operations not supported in standalone mode - Added package-info.java with documentation for the standalone package
@cstamas do you want to have a look at resolver and see if that would work ? |
@gnodet sure! |
@@ -112,6 +112,22 @@ under the License. | |||
<groupId>org.apache.maven.resolver</groupId> | |||
<artifactId>maven-resolver-impl</artifactId> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am unsure are these deps really needed here, maybe only for test?
As if you make them required, you make apache transport or basic connector "mandatory". I'd rather put back these into test scope of maven-impl and let "mima-like use case" user pick deps he needs instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved out the transports and kept named locks and connectors, as they are really the only implementation. If needed, we can revisit later.
Not to mention: now if this pulled out, what happens to maven-testing supplier? Should they be the same? |
Maven testing uses mocks, so not really affected. |
Resolve #9673 |
JIRA issue: MNG-8637
This commit moves the Standalone API implementation from the test directory to the main source directory, making it available for reuse outside of tests.
The Standalone API provides a way to run Maven API in a standalone mode (without the full Maven environment), primarily for testing and specialized execution scenarios. This is now the proper way to utilize Maven 4 in MIMA-like scenarios.
Key changes: