add include of bsp_defs.h so that a BSP can override defines (for exa… #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple idle stack size)
|
Ok. Seems like bsp/bsp_defs.h is not a 'standard' file in mynewt BSPs. |
Style check summaryNo suggestions at this time! |
|
Any chance of getting this PR in? |
|
I believe we should use a MYNEWT_VAL for this, instead of the header file. |
|
Hi this was my original PR method, adding a syscfg (as for the main task
stack size). However this was not approved... and the method of an include
suggested.
brian
envoyé depuis ma nuage
…On Fri, 27 Mar 2020, 18:53 Miguel Azevedo, ***@***.***> wrote:
@wes3 <https://github.com/wes3> @andrzej-kaczmarek
<https://github.com/andrzej-kaczmarek> @sjanc <https://github.com/sjanc> ^
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2223 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMIHRIH7O7L7GXUC45VZJ6TRJTR2XANCNFSM4LAKKU5Q>
.
|
|
Ok, I looked at #2138. Still hard to find out exactly why do you need redefine idle task's stack size. |
|
The need is to have an ajustable size for the stack depending on the bsp,
as during low power entry/exit (which takes place in the idle task) it is
neccessary to run different code blocks to deinit/reinit the peripherals on
a specific board.
This can involve calling up to the bsp and/or app (see my other PR for the
method I propose to integrate this kind of system)
envoyé depuis ma nuage
…On Fri, 27 Mar 2020, 20:30 Miguel Azevedo, ***@***.***> wrote:
Ok, I looked at #2138 <#2138>.
Still hard to find out exactly why do you need redefine idle task's stack
size.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2223 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMIHRIHEOZOVLZHC2SJKBK3RJT5E7ANCNFSM4LAKKU5Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bsp_defs.h in a specific BSP can redefine the idle stack size without changing the core of mynewt