newt/build: Workaround for whole-archive flag #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work for arm builds and pic32 (except for Windows). Mac not tested by me. |
kasjer
previously approved these changes
Jun 6, 2025
kasjer
reviewed
Jun 7, 2025
Flag whole-archive is not supported on Mac and it was causing CI failures. Now instead of using this flag with .a file we just pass a text file with list of all object files from package to the linker. So now it looks like this: @pkg.list instead of: --whole-archive pkg.a --no-whole-archive Passing list of object files will result in pulling unreferenced object code just like in case of whole-archive flag and should work with all compilers.
kasjer
approved these changes
Jun 26, 2025
Comment on lines
+1393
to
+1396
| // the file with list of all paths to object files | ||
| // from the library will be created, which later | ||
| // can be passed with @ to the linker. | ||
| func (c *Compiler) CompileArchive(outputFile string, createList bool) error { |
There was a problem hiding this comment.
maybe space should be use here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag whole-archive is not supported on Mac and it was causing CI failures. Now instead of using this flag with .a file we just pass a text file with list of all object files from package to the linker. So now it looks like this:
@pkg.list
instead of:
--whole-archive pkg.a --no-whole-archive
Passing list of object files will result in pulling unreferenced object code just like in case of whole-archive flag and should work with all compilers.