Skip to content

MINIFICPP-2502 Add processorBulletins C2 metric node to FlowInformation #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2502

Depends on #1918


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2502 branch 2 times, most recently from 032cc42 to 90baa4e Compare January 28, 2025 19:05
@lordgamez lordgamez marked this pull request as ready for review January 29, 2025 08:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 36 out of 37 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • conf/minifi.properties: Language not supported
Comments suppressed due to low confidence (2)

libminifi/src/core/ProcessGroup.cpp:495

  • [nitpick] Consider standardizing or documenting the delimiter used for building the group path to ensure consistency, and verify that any trailing spaces are intentional.
path.insert(0, parent->getName() + " / ");

libminifi/include/core/ProcessorConfig.h:44

  • Ensure that the field 'bulletinLevel' is consistently initialized and handled across all processor configuration code paths to avoid unintentional empty values.
std::string bulletinLevel;

@lordgamez lordgamez changed the base branch from MINIFICPP-2512 to main April 15, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants