-
Notifications
You must be signed in to change notification settings - Fork 94
MINIFICPP-2502 Add processorBulletins C2 metric node to FlowInformation #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lordgamez
wants to merge
2
commits into
apache:main
Choose a base branch
from
lordgamez:MINIFICPP-2502
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
032cc42
to
90baa4e
Compare
szaszm
reviewed
Feb 13, 2025
4d5fc3d
to
bf3e783
Compare
90baa4e
to
1e8a70d
Compare
1e8a70d
to
5c4804e
Compare
0d16584
to
657ccae
Compare
37c777f
to
403358e
Compare
657ccae
to
986cc75
Compare
403358e
to
a881933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 36 out of 37 changed files in this pull request and generated no comments.
Files not reviewed (1)
- conf/minifi.properties: Language not supported
Comments suppressed due to low confidence (2)
libminifi/src/core/ProcessGroup.cpp:495
- [nitpick] Consider standardizing or documenting the delimiter used for building the group path to ensure consistency, and verify that any trailing spaces are intentional.
path.insert(0, parent->getName() + " / ");
libminifi/include/core/ProcessorConfig.h:44
- Ensure that the field 'bulletinLevel' is consistently initialized and handled across all processor configuration code paths to avoid unintentional empty values.
std::string bulletinLevel;
986cc75
to
fc130f5
Compare
a881933
to
37b3f3f
Compare
8 tasks
fc130f5
to
d40b068
Compare
37b3f3f
to
a776dff
Compare
a776dff
to
2612481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2502
Depends on #1918
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.