-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13982 - Web client - body as string and get request URI for response entity #9500
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting together this improvement @pvillard31. The general changes look good. I noted the importance of highlighting that the String request body will be encoded as UTF-8. I also noted some suggestions on the URI for the response.
...ons/nifi-web-client-api/src/main/java/org/apache/nifi/web/client/api/HttpResponseEntity.java
Outdated
Show resolved
Hide resolved
...ons/nifi-web-client-api/src/main/java/org/apache/nifi/web/client/api/HttpResponseEntity.java
Outdated
Show resolved
Hide resolved
...ns/nifi-web-client-api/src/main/java/org/apache/nifi/web/client/api/HttpRequestBodySpec.java
Outdated
Show resolved
Hide resolved
...ns/nifi-web-client-api/src/main/java/org/apache/nifi/web/client/api/HttpRequestBodySpec.java
Outdated
Show resolved
Hide resolved
...ons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardHttpResponseEntity.java
Outdated
Show resolved
Hide resolved
...mmons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardWebClientService.java
Outdated
Show resolved
Hide resolved
...ons/nifi-web-client-api/src/main/java/org/apache/nifi/web/client/api/HttpResponseEntity.java
Outdated
Show resolved
Hide resolved
...ons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardHttpResponseEntity.java
Outdated
Show resolved
Hide resolved
...ons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardHttpResponseEntity.java
Outdated
Show resolved
Hide resolved
...ons/nifi-web-client/src/main/java/org/apache/nifi/web/client/StandardHttpResponseEntity.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Handermann <[email protected]>
...ons/nifi-web-client-api/src/main/java/org/apache/nifi/web/client/api/HttpResponseEntity.java
Outdated
Show resolved
Hide resolved
…/web/client/api/HttpResponseEntity.java
Thanks @exceptionfactory - committed the suggested changes. I didn't realize that |
Summary
NIFI-13982 - Web client - body as string and get request URI for response entity
In the web client API, we currently have in
HttpRequestBodySpec
:It would be convenient to also have:
Especially when the payload is very small and easy to craft.
In addition, in
HttpResponseEntity
, there is no way to know what endpoint has been accessed to generate that response. Having the possibility to retrieved the requested endpoint from the response entity might be useful when there is a separation between processors and controller services, in particular when generating the provenance events at processor level where adding the transit URI is useful for data lineage.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000
NIFI-00000
Pull Request Formatting
main
branchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check
Licensing
LICENSE
andNOTICE
filesDocumentation