NUTCH-3115 Extend access to all filter plugin constructor call args to user's POJO in Arbitrary Indexer #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-nagel
changed the title
sebastian-nagel
approved these changes
Jul 12, 2025
|
Still banging on this today. If we still have time, I'd like to do a bit more work so the new flag for all fields access can apply to each field/class individually. That'll be easier to update an existing nutch-site to start using it without interfering with previous index-arbitrary defs. |
… updated JUnit tests, improved logging
sebastian-nagel
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the update to the Arbitrary Indexing Filter plugin that lets it optionally pass all its own constructor args (NutchDocument, Parse, Text (from Hadoop), CrawlDatum, and Inlinks) to the user's POJO constructor for their custom processing. There's a small typo correction in a logging statement, too, that output a class name when it claimed to output a method name, included here at no extra cost! :)