tcp_recvfrom.c:resolve issue in tcp_recvhandler #15287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n tcp_recvhandler calls tcp_newdata to clear dev->d_iob Signed-off-by: wangchen <[email protected]>
github-actions
bot
added
Area: Networking
1 task
acassis
approved these changes
Dec 19, 2024
| @@ -408,12 +409,37 @@ static uint16_t tcp_recvhandler(FAR struct net_driver_s *dev, | |||
|
|
|||
| tcp_sender(dev, pstate); | |||
|
|
|||
| if ((flags & TCP_ACKDATA) != 0) | |||
There was a problem hiding this comment.
@wangchen61698 suggestion: please include a comment before this block you added here to explain the idea of doing this way
1 task
xiaoxiang781216
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
malloc a new iob to handle psock_send_eventhandler when tcp_recvhandler calls tcp_newdata to clear dev->d_iob
Impact
tcp_recvhandler
Testing
Manual verification