Fixed errors in CI build tests for pull request #15351 #15352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: arm
xiaoxiang781216
approved these changes
Dec 26, 2024
kywwilson11
force-pushed
the
efm32_gd32f4xx_fixes
branch
2 times, most recently
from
81e5d7f to
16db02c
Compare
There were two simple errors when running ci tests on pull apache#15351. These errors were unrelated to that pull. After investigating I found two simple errors. 1. The len variable was likely a typo that should have been the function argument, ien. 2. The spinlock_t lock was defined in a section dependent on CONFIG_SERIAL_TERMIOS. However, the spinlock_t lock was used in code that did not require the SERIAL_TERMIOS config. Therefore errors resulted. imxrt_edma_s missing lock variable CI build tests noted that the variable g_edma was referencing a lock variable that did not exist in the structure. This change adds that missing lock as a spinlock_t type. Remove unused flags variable from imxrt_dmach_stop Removed extra =
kywwilson11
force-pushed
the
efm32_gd32f4xx_fixes
branch
from
588bdd9 to
518d90c
Compare
|
Hello, |
lupyuen
added a commit
to lupyuen2/wip-nuttx
that referenced
this pull request
Dec 30, 2024
An extra `lock` appears in gd32f4xx_serial due to 2 conflicting PRs: - apache#7011 - apache#15352 This PR removes the extra `lock` in gd32f4xx_serial.
lupyuen
added a commit
to lupyuen2/wip-nuttx
that referenced
this pull request
Dec 30, 2024
An extra `lock` appears in imxrt_edma due to 2 conflicting PRs: - apache#15352 - apache#15353 This PR removes the extra `lock` in imxrt_edma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
There were two simple errors when running ci tests on pull #15351. These errors were unrelated to that pull. After investigating I found two simple errors.
Testing
Re-built Nuttx with fixes. No build errors after changes.