xtensa/esp32: add lock for async operation work #15385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g_work as singleton can be changed by context switching, but previous one async operation have not finished yet. adapt based on: 10a1d17
github-actions
bot
added
Arch: xtensa
xiaoxiang781216
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
g_work as singleton can be changed by context switching, but previous one async operation have not finished yet.
adapt based on: 10a1d17
Impact
one additonal mutex is used for g_work to keep the sequence correctly.
Testing
reproduce and verified by below steps
Variable g_wrok is sent to work_queue() function and set value to this variable.
Another context changes g_work by call esp32_async_op during step 1. g_work of Step 1 is changed because g_work is singleton.
Step 1 hanges because g_work of step 1 are cleared by step 2.