-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm/qemu: add cortex-r5 support #15593
Conversation
This revise armv7-r/ header files needed to support QEMU cortex-r5 virtual process for armv7-r family. Signed-off-by: Yanfeng Liu <[email protected]>
This adds support for QEMU Cortex-R5 virtual processor on existing QEMU Cortex-A7 code base with profile support in `armv7-r/` and `armv7-a/`. Signed-off-by: Yanfeng Liu <[email protected]>
[Experimental Bot, please feedback here] No, this PR description does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details and depth required for a proper review. Here's a breakdown of the missing information: Summary:
Impact: While the "Impacts" section mentions QEMU emulated ARMv7 boards, it needs to address all the specific points required:
Testing:
In short, the PR description needs significant expansion to meet the requirements. Provide more context, details, and specific answers to all the questions posed in the template. This will make it easier for reviewers to understand and evaluate the changes. |
This adds support for qemu-armv7r board with flat mode sample config for using with QEMU emulated Cortex-R5 processor. Signed-off-by: Yanfeng Liu <[email protected]>
#ifdef CONFIG_ARCH_ARMV7R | ||
/* dont return per armv7-r/arm_head.S design */ | ||
|
||
nx_start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we unify armv7-a and armv7-r start code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is per this commet. If it is still needed, maybe in the future we can check if armv7-a side can take the same approach for unifying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is: either let armv7-r call nx_start in assembly code, or remove nx_start in assemly code in armv7-a arm_head.S.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #15624
****************************************************************************/ | ||
|
||
/**************************************************************************** | ||
* Name: imx_bringup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qemu_bringup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! see #15620
Summary
This adds QEMU emulated Cortex-R5 chip with virt sample board config.
Thanks @hujun260 for the discussions.
Impacts
QEMU emulated armv7 boards
Testing
qemu-armv7a:nsh
,qemu-armv7r:nsh