-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/qemu-armv7a: revises knsh config #15626
Conversation
[Experimental Bot, please feedback here] The PR summary is good, but lacks some detail on how the changes work. For instance, how is memory reduced? What specific changes enable graceful shutdown and more ostest cases? The Impact and Testing sections are too brief and don't meet the requirements. Here's a revised version suggesting how to improve the PR description: SummaryThis PR adjusts the
Impact
TestingI confirm that changes are verified on local setup and works as intended:
Testing logs before change:
Testing logs after change:
|
This adjusts `qemu-armv7a:knsh` with following changes: - use smaller flash/memory so that `-m 1024` can be omitted. - use ELF_EXECUTABLE for apps to allow easier app debugging. - enable graceful shutdown from NSH command. - enable more cases of ostest (e.g. vfork, pthread_exit etc). Signed-off-by: Yanfeng Liu <[email protected]>
b8318ce
to
fb2109a
Compare
@yf13 You could add partner email to your personal github account |
Summary
This adjusts
qemu-armv7a:knsh
with following points:-m 1024
can be skipped.Impacts
The
qemu-armv7a:knsh
target.Testing
qemu-armv7a:nsh