Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bp-16015} tools/checkpatch: Use gmake on BSD, make otherwise. #16069

Merged
merged 1 commit into from
Mar 26, 2025
Merged

[bp-16015} tools/checkpatch: Use gmake on BSD, make otherwise. #16069

merged 1 commit into from
Mar 26, 2025

Conversation

jerpelea
Copy link
Contributor

Summary

  • BSD has its own BSD Make that is incompatible with GNU Make.
  • When BSD is detected use (gnu) gmake in place of (bsd) make.
  • This fixes nxstyle build inside tools/checkpatch.sh.

Impact

RELEASE

Testing

CI

@cederom @jerpelea
tools/checkpatch: Use gmake on BSD, make otherwise.
ed65315 
* BSD has its own BSD Make that is incompatible with GNU Make.
* When BSD is detected use (gnu) gmake in place of (bsd) make.
* This fixes nxstyle build inside tools/checkpatch.sh.

Signed-off-by: Tomasz 'CeDeROM' CEDRO <[email protected]>
@jerpelea jerpelea changed the base branch from master to releases/12.9 March 25, 2025 11:14
@github-actions github-actions bot added Area: Tooling Size: XS The size of the change in this PR is very small labels Mar 25, 2025
cederom
cederom approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jerpelea and me :D

@lupyuen lupyuen merged commit 80fc99a into apache:releases/12.9 Mar 26, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acassis acassis acassis approved these changes

@cederom cederom cederom approved these changes

@lupyuen lupyuen lupyuen approved these changes

@raiden00pl raiden00pl Awaiting requested review from raiden00pl

@asf-gitbox asf-gitbox Awaiting requested review from asf-gitbox

Assignees
No one assigned
Labels
Area: Tooling Size: XS The size of the change in this PR is very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerpelea @acassis @cederom @lupyuen