-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated issue & Support array result #517
Conversation
61efce6
to
2e75919
Compare
8a654f2
to
a98569a
Compare
d2369e2
to
1e5403e
Compare
@style95 when build this pr in travis, it will execute its dependent openwhisk repo's test case, and it would be failed: https://app.travis-ci.com/github/apache/openwhisk-cli/builds/254265161, i copied the failed result as below
But strange thing is, the test case is successful when just build openwhisk repo's pr: apache/openwhisk#5308 in travis ci
|
It seems not. Line 59 in 92c251f
|
This is avoid test case avoid below problem: java.net.BindException: [/127.0.0.1:25520] Address already in use After added this change, every test case will used a random port.
90e546c
to
b400c17
Compare
- openwhisk-wskdeploy - openwhisk-client-go
If return array, make the result return empty string
377fc45
to
ba3b6ce
Compare
@@ -86,6 +86,7 @@ cd $OPENWHISK_HOME | |||
#./tools/travis/setup.sh | |||
|
|||
# Fire up the cluster | |||
echo 'limit_invocations_per_minute: 120' >> $OPENWHISK_HOME/ansible/environments/local/group_vars/all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this configuration make below relative test case stable
command will retry to due to network error: exit code = 1
stdout:
stderr: error: Unable to delete API: Too many requests in the last minute (count: 66, allowed: 60). (code 717d6491a6785e7c2059b60135880a9e)
command will retry to due to network error: exit code = 1
stdout:
stderr: error: Unable to delete API: API deletion failure: API '/CLI_APIGWTEST11_bp' does not exist.
org.apache.openwhisk.core.cli.test.ApiGwCliTests > Cli Wsk api creation with path parameters with swagger should verify delete basepath/path FAILED
org.scalatest.exceptions.TestFailedException: /home/travis/gopath/src/github.com/apache/openwhisk/bin/wsk -i --apihost 172.17.0.1 --apiversion v1 api create --auth 23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP /CLI_APIGWTEST11_bp /path get CLI_APIGWTEST11_action --apiname CLI_APIGWTEST11 API Name
error: Unable to create API: Too many requests in the last minute (count: 64, allowed: 60). (code aa221bc7c98c15b86614fd28bae0c013)
exit code: 1 was not equal to 0
at org.scalatest.MatchersHelper$.indicateFailure(MatchersHelper.scala:343)
at org.scalatest.Matchers$AnyShouldWrapper.shouldBe(Matchers.scal
d777cc2
to
dc4ce7c
Compare
f997e26
to
0524330
Compare
Avoid does not find pureconfig during testing CLI tests
Just for system.basic.WskCliActivationTests
ab20c81
to
fb9a5e3
Compare
@@ -82,22 +82,42 @@ cd $TRAVIS_BUILD_DIR | |||
# | |||
cd $OPENWHISK_HOME | |||
|
|||
# Build openwhisk image to keep test case code consistent with latest openwhisk core code | |||
./gradlew distDocker -PdockerImagePrefix=openwhisk -PdockerImageTag=latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comment said, build openwhisk image to keep test case code consistent with latest openwhisk core code
@@ -25,10 +25,14 @@ gradle.ext.openwhisk = [ | |||
|
|||
gradle.ext.scala = [ | |||
version: '2.12.7', | |||
compileFlags: ['-feature', '-unchecked', '-deprecation', '-Xfatal-warnings', '-Ywarn-unused-import'] | |||
depVersion : '2.12', | |||
compileFlags: ['-feature', '-unchecked', '-deprecation', '-Ywarn-unused-import'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to deprecated lib issue, i tried to upgrade SSL lib, but WskCliActivationTests
test case still failed with upgraded lib, and i didn't solve it for long time :(
In orde to make ./gradlew --console=plain :tests:test --tests="system.basic.WskCliActivationTests"
test case passed and make this pr merged, i removed '-Xfatal-warnings'
in this pr. (Fyi, -Xfatal-warnings
means warnings as errors
)
But normally, should keep '-Xfatal-warnings'
, so i created a issue here: #518, we can add '-Xfatal-warnings'
back and upgrade SSL lib to make WskCliActivationTests
passed in another separate pr
I think other upstream guys can open pr to solve it as well. i didn't solve it in my local.
Btw, only need to modify below method (Other upgraded points are ok)
concrete content: Support array result #516 (comment)