Add ZOOKEEPER_HOSTS as an optional property #5435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5435 +/- ##
===========================================
+ Coverage 58.52% 76.60% +18.08%
===========================================
Files 241 241
Lines 14632 14634 +2
Branches 616 607 -9
===========================================
+ Hits 8563 11211 +2648
+ Misses 6069 3423 -2646
... and 135 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
style95
force-pushed
the
add-zookeeper-host
branch
from
caf6e8c
to
a066119
Compare
style95
commented
Aug 16, 2023
| @@ -186,7 +188,8 @@ object Invoker { | |||
|
|
|||
| // --uniqueName is defined with a valid value, id is empty, assign an id via zookeeper | |||
| case CmdLineArgs(Some(unique), None, _, overwriteId) => | |||
| if (config.zookeeperHosts.startsWith(":") || config.zookeeperHosts.endsWith(":")) { | |||
| if (config.zookeeperHosts.startsWith(":") || config.zookeeperHosts.endsWith(":") || | |||
| config.zookeeperHosts.equals("")) { | |||
There was a problem hiding this comment.
It will make sure zookeeper hosts are configured when the ID assignor is used.
|
Without this change, invokers with the ID assignor can not be deployed. |
ningyougang
approved these changes
Sep 15, 2023
|
LGTM 👍 |
mtt-merz
pushed a commit
to mtt-merz/openwhisk
that referenced
this pull request
Oct 22, 2023
* Add ZOOKEEPER_HOSTS as an optional property * Check if zookeeper hosts are empty * Apply scalaFmt (cherry picked from commit 6375c96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As
ZOOKEEPER_HOSTSis removed from the required properties, it is no longer transformed into the whisk config from the environment variables.But when the instance id assigned is used, the zookeeper host becomes a required property.
This change is to make it an optional property.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: