Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message skipping typo #5448

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix: message skipping typo #5448

merged 1 commit into from
Oct 28, 2023

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Oct 18, 2023

Description

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0o001
Thank you for your contribution.

@codecov-commenter
Copy link

Codecov Report

Merging #5448 (1c916df) into master (6f11d48) will decrease coverage by 72.36%.
The diff coverage is n/a.

❗ Current head 1c916df differs from pull request most recent head 0873d49. Consider uploading reports for the commit 0873d49 to get more accurate results

@@            Coverage Diff             @@
##           master   #5448       +/-   ##
==========================================
- Coverage   76.87%   4.52%   -72.36%     
==========================================
  Files         241     241               
  Lines       14644   14644               
  Branches      619     619               
==========================================
- Hits        11258     663    -10595     
- Misses       3386   13981    +10595     

see 206 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@style95 style95 merged commit a4f4b2d into apache:master Oct 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants