-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bigger queue size #5453
Use bigger queue size #5453
Conversation
@@ -226,7 +216,7 @@ object AkkaContainerClient { | |||
tid: TransactionId, | |||
as: ActorSystem, | |||
ec: ExecutionContext): Seq[(Int, Option[JsObject])] = { | |||
val connection = new AkkaContainerClient(host, port, timeout, 1) | |||
val connection = new AkkaContainerClient(host, port, timeout, queueSize) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed this change fix the CI tests of nodejs runtime.
@joni-jones |
Codecov Report
@@ Coverage Diff @@
## master #5453 +/- ##
=======================================
Coverage 76.52% 76.53%
=======================================
Files 241 241
Lines 14644 14645 +1
Branches 619 609 -10
=======================================
+ Hits 11206 11208 +2
+ Misses 3438 3437 -1
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I see that the default value for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Merging.
Handle #5452
Description
When sending concurrent requests, a queue full error happens.
So I increased the queue size according to this value in the nodejs runtime repo.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: