Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bigger queue size #5453

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

style95
Copy link
Member

@style95 style95 commented Oct 29, 2023

Handle #5452

Description

When sending concurrent requests, a queue full error happens.
So I increased the queue size according to this value in the nodejs runtime repo.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@@ -226,7 +216,7 @@ object AkkaContainerClient {
tid: TransactionId,
as: ActorSystem,
ec: ExecutionContext): Seq[(Int, Option[JsObject])] = {
val connection = new AkkaContainerClient(host, port, timeout, 1)
val connection = new AkkaContainerClient(host, port, timeout, queueSize)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this change fix the CI tests of nodejs runtime.

@style95
Copy link
Member Author

style95 commented Oct 29, 2023

@joni-jones
Could you take a look?

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #5453 (168735d) into master (a4f4b2d) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 168735d differs from pull request most recent head a739454. Consider uploading reports for the commit a739454 to get more accurate results

@@           Coverage Diff           @@
##           master    #5453   +/-   ##
=======================================
  Coverage   76.52%   76.53%           
=======================================
  Files         241      241           
  Lines       14644    14645    +1     
  Branches      619      609   -10     
=======================================
+ Hits        11206    11208    +2     
+ Misses       3438     3437    -1     
Files Coverage Δ
...whisk/core/containerpool/AkkaContainerClient.scala 71.69% <50.00%> (+0.54%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joni-jones
Copy link
Contributor

I see that the default value for max-connections is 128. So the queue might consume slightly more memory, but it should not have any impact. Overall, I think this fix makes sense.

Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Merging.

@dgrove-oss dgrove-oss merged commit ae0c4e0 into apache:master Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants