HDDS-12062. Recon - Error handling in NSSummaryTask to avoid data inconsistencies. #7723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR change fixes improper error handling in processing of NSSummary task events.
Please describe your PR in detail:
Robust error handling is needed in Recon OM tasks to avoid data inconsistency. E.g. improper exception handling for a partial batch of events processing. E.g. it could be possible that some events in the NSSummary task are already processed and flushed to DB for some keys having the same parentId as those keys which are failed. So re-processing of those same events should be handled separately for failed events in a set.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12062
How was this patch tested?
This patch is tested with junit test cases.