HDDS-12134. Implement Snapshot Cache lock for OM Bootstrap #7745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I97e0e0e28736cc51bfb23c45d3750cf721a9689e
Change-Id: Ia5ecb2b863ba2ea2482ac2824aa7b6df98939bb5
smengcl
reviewed
Jan 25, 2025
| this.readLock = lock.readLock(); | ||
| this.writeLock = lock.writeLock(); | ||
| this.snapshotRefThreadIds = new ConcurrentHashMap<>(); | ||
| this.lockTimeout = lockTimeout; |
There was a problem hiding this comment.
Let's print an INFO level log here that the snapshot cache lock timeout is set to X ms.
smengcl
reviewed
Jan 26, 2025
| @@ -97,10 +122,21 @@ public void invalidate(UUID key) { | |||
| if (v == null) { | |||
| LOG.warn("SnapshotId: '{}' does not exist in snapshot cache.", k); | |||
| } else { | |||
| readLock.lock(); | |||
There was a problem hiding this comment.
This is in invalidate(). Should it use writeLock instead?
smengcl
reviewed
Jan 26, 2025
Comment on lines
+277
to
+282
| while (lockCnt > 0) { | ||
| try { | ||
| lockReleased.await(lockTimeout, TimeUnit.MILLISECONDS); | ||
| } catch (InterruptedException e) { | ||
| throw new IOException("Error while waiting for locks to be released.", e); | ||
| } |
There was a problem hiding this comment.
Does Condition await() throw InterruptedException upon timeout? I don't think so. You should check the return value instead if that is the intention.
smengcl
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Can we add more test cases to verify that the states of those new internal structures are behaving as expected upon cache operations? e.g. snapshotRefThreadIds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implementing a lock for this snapshot cache would prevent any newer threads from requesting a snapshot rocksdb handle from the snapshot cache. Thus any operation under this lock will have a consistent view of the entire snapshot.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12134
How was this patch tested?
Adding unit tests.