HDDS-12135. Set RM default deadline to 12 minutes and the datanode offset to 6 minutes #7747
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We recently found that delete commands can run for a long time once picked off the queue, and the default of a 10 minute deadline on SCM and 30 seconds less deadline on the datanodes can result in currently running commands being seen as expired in SCM.
This PR is to make the defaults less aggressive - giving a SCM / RM timeout of 12 minutes and a datanode timeout of 6 minutes. That way, there is longer for commands to be processed before RM will resend them.
With the throttling that RM employs, there should not be a large number of commands on the queue anyway, as the goal of RM is to schedule only the number of commands which can be processed in a heartbeat or two.
Other related Jiras to this one are: HDDS-12127, HDDS-12115, HDDS-12114
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12135
How was this patch tested?
Simple config change. No new tests added or modified.