ut: add serialize/deserialize tests for spec #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 14, 2024
|
|
||
| #[test] | ||
| fn test_data_file_meta_serialize_deserialize() { | ||
| let json_data = r#" |
There was a problem hiding this comment.
Hi, @devillove084
This fixture appears to be just the schema of ManifestFileMeta. How is ManifestFileMeta data stored on disk?
There was a problem hiding this comment.
We should also have DataFileMeta's datatype and DataFileMeta on disk format.
There was a problem hiding this comment.
The default manifest file is of avro format. I think we should also generate a corresponding manifest file to verify the deserialize. But may be we should support avro/orc reader first ?
There was a problem hiding this comment.
The default manifest file is of
avroformat. I think we should also generate a corresponding manifest file to verify the deserialize. But may be we should support avro/orc reader first ?
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #26