-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add H2 version of new durable state tests #280
Open
pjfanning
wants to merge
12
commits into
apache:main
Choose a base branch
from
pjfanning:db-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+140
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Mar 22, 2025
•
edited
Loading
edited
- follow up to fix: postgres durable state schemaName change leads to write errors (#275) #276
- I looked at the SQL files for Oracle, MySQL and SQLServer and think it is best to not mess with them
- My view is to wait for people who want schema support to work for Oracle, MySQL and SQLServer to help in setting up tests, etc.
- afaics MySQL does not differentiate between databases and schemas - https://dev.mysql.com/doc/refman/8.4/en/glossary.html#glos_schema - so probably best to encourage MySQL users just to create extra databases instead of schemas
@patsta32 does this look ok to you? If I have time, I might look at adding schema tests for other pekko-persistence-jdbc use cases - eg journals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- core/src/main/resources/schema/h2/h2-create-schema-legacy.sql: Language not supported
- core/src/main/resources/schema/h2/h2-create-schema.sql: Language not supported
- core/src/main/scala/org/apache/pekko/persistence/jdbc/testkit/internal/SchemaUtilsImpl.scala: Language not supported
- core/src/test/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/DurableStateStorePluginSpec.scala: Language not supported
- integration-test/src/test/scala/org/apache/pekko/persistence/jdbc/integration/PostgresDurableStateStorePluginSpec.scala: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.