PHOENIX-7474 Migrate IndexTool tables and make sure they are created #2031
+754
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @swaroopak @kadirozde I provided some description on the ticket about this change and why it is needed https://issues.apache.org/jira/browse/PHOENIX-7474 Let me know if you have any questions. |
|
@richardantal, the PR looks good to me overall. Thank you for fixing this issue. I will approve the PR after a successful build and test run (expect known test failures). |
stoty
reviewed
Dec 2, 2024
| import static org.apache.phoenix.query.QueryConstants.SYSTEM_SCHEMA_NAME; | ||
|
|
||
| /** | ||
| * An MR job to populate the index table from the data table. |
There was a problem hiding this comment.
This does not look like an MR tool to me, it does not implement the right interface for that.
Rename to IndexToolUtil or IndexToolTableUtil ?
richardantal
force-pushed
the
PHOENIX-7474
branch
from
34ff76d to
7c2b511
Compare
|
I see that these changes cause some test failures, I'll fix them soon. |
richardantal
force-pushed
the
PHOENIX-7474
branch
from
7c2b511 to
f2470b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.