Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-7482 Replace uses of org.iq80.snappy:snappy with org.xerial.snappy:snappy-java #2039

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PHOENIX-7482 Replace uses of org.iq80.snappy:snappy with org.xerial.snappy:snappy-java #2039

wants to merge 2 commits into from
+31 −20

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Dec 9, 2024

No description provided.

@apurtell apurtell requested review from stoty and virajjasani December 9, 2024 21:04
stoty
stoty approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

virajjasani
virajjasani approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@apurtell
Copy link
Contributor Author

apurtell commented Dec 19, 2024 •
edited
Loading

Pushed an update, see 24963c3
Xerial snappy cannot be shaded because there is a JNI component. Shading can't/won't rewrite the native symbols. The result is runtime link failures. We ran a local precommit at $dayjob and it passed, this issue was found later, so there may not be test coverage for this case.

@stoty
Copy link
Contributor

stoty commented Jan 9, 2025

It seems that Hadoop also depends on this library.

I wonder if that could cause JNI version conflict problems when running with external Hadoop ?
I haven't dug into this, just a thought.
(Actually, I'm not sure how we handle native dependencies when using external Hadoop at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

@stoty stoty Awaiting requested review from stoty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apurtell @stoty @virajjasani