Make ingestion offset delay metric configurable #14074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmayya
added
Configuration
gortiz
reviewed
Sep 25, 2024
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java
Outdated
Show resolved
Hide resolved
gortiz
reviewed
Sep 25, 2024
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14074 +/- ##
============================================
+ Coverage 61.75% 63.97% +2.22%
- Complexity 207 1538 +1331
============================================
Files 2436 2596 +160
Lines 133233 143346 +10113
Branches 20636 21956 +1320
============================================
+ Hits 82274 91705 +9431
+ Misses 44911 44890 -21
- Partials 6048 6751 +703
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
approved these changes
Sep 25, 2024
ege-st
reviewed
Sep 25, 2024
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java
Outdated
Show resolved
Hide resolved
9aman
added a commit
to 9aman/pinot
that referenced
this pull request
Sep 30, 2024
This reverts commit bba61ee.
KKcorps
pushed a commit
to KKcorps/incubator-pinot
that referenced
this pull request
Oct 1, 2024
This reverts commit bba61ee.
KKcorps
added a commit
that referenced
this pull request
Oct 1, 2024
…4127) This reverts commit bba61ee. Co-authored-by: Kartik Khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ingestion offset lag metric currently makes a request to kafka broker to get the latest offset on every update.
However, this has lead to an increasing amount of load on kafka brokers for multiple users.
The PR adds a way to enable/disable this metric and also configure its interval using the following properties in the server or cluster configs