Skip to content

test the checking logic of whether segment preloading is enabled for upsert table #14085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klsince merged 1 commit into from
Sep 26, 2024
Merged

test the checking logic of whether segment preloading is enabled for upsert table #14085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 53 additions & 12 deletions ...est/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import com.google.common.collect.Lists;
import java.io.File;
import java.util.concurrent.ExecutorService;
import org.apache.pinot.segment.local.data.manager.TableDataManager;
import org.apache.pinot.spi.config.table.HashFunction;
import org.apache.pinot.spi.config.table.TableConfig;
Expand All @@ -32,6 +33,8 @@

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;

Expand All @@ -44,10 +47,9 @@ public class TableUpsertMetadataManagerFactoryTest {
public void testCreateForDefaultManagerClass() {
UpsertConfig upsertConfig = new UpsertConfig(UpsertConfig.Mode.FULL);
upsertConfig.setHashFunction(HashFunction.NONE);
Schema schema =
new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension("myCol", FieldSpec.DataType.STRING)
.setPrimaryKeyColumns(Lists.newArrayList("myCol")).build();
Schema schema = new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension("myCol", FieldSpec.DataType.STRING).setPrimaryKeyColumns(Lists.newArrayList("myCol"))
.build();
TableDataManager tableDataManager = mock(TableDataManager.class);
when(tableDataManager.getTableDataDir()).thenReturn(new File(RAW_TABLE_NAME));
_tableConfig =
Expand All @@ -57,19 +59,18 @@ public void testCreateForDefaultManagerClass() {
assertNotNull(tableUpsertMetadataManager);
assertTrue(tableUpsertMetadataManager instanceof ConcurrentMapTableUpsertMetadataManager);
tableUpsertMetadataManager.init(_tableConfig, schema, tableDataManager);
assertTrue(tableUpsertMetadataManager.getOrCreatePartitionManager(0)
instanceof ConcurrentMapPartitionUpsertMetadataManager);
assertTrue(tableUpsertMetadataManager.getOrCreatePartitionManager(
0) instanceof ConcurrentMapPartitionUpsertMetadataManager);
}

@Test
public void testCreateForManagerClassWithConsistentDeletes() {
UpsertConfig upsertConfig = new UpsertConfig(UpsertConfig.Mode.FULL);
upsertConfig.setHashFunction(HashFunction.NONE);
upsertConfig.setEnableDeletedKeysCompactionConsistency(true);
Schema schema =
new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension("myCol", FieldSpec.DataType.STRING)
.setPrimaryKeyColumns(Lists.newArrayList("myCol")).build();
Schema schema = new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension("myCol", FieldSpec.DataType.STRING).setPrimaryKeyColumns(Lists.newArrayList("myCol"))
.build();
TableDataManager tableDataManager = mock(TableDataManager.class);
when(tableDataManager.getTableDataDir()).thenReturn(new File(RAW_TABLE_NAME));
_tableConfig =
Expand All @@ -79,7 +80,47 @@ public void testCreateForManagerClassWithConsistentDeletes() {
assertNotNull(tableUpsertMetadataManager);
assertTrue(tableUpsertMetadataManager instanceof ConcurrentMapTableUpsertMetadataManager);
tableUpsertMetadataManager.init(_tableConfig, schema, tableDataManager);
assertTrue(tableUpsertMetadataManager.getOrCreatePartitionManager(0)
instanceof ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes);
assertTrue(tableUpsertMetadataManager.getOrCreatePartitionManager(
0) instanceof ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes);
}

@Test
public void testEnablePreload() {
UpsertConfig upsertConfig = new UpsertConfig(UpsertConfig.Mode.FULL);
upsertConfig.setHashFunction(HashFunction.NONE);
upsertConfig.setEnablePreload(true);
upsertConfig.setEnableSnapshot(true);
Schema schema = new Schema.SchemaBuilder().setSchemaName(RAW_TABLE_NAME)
.addSingleValueDimension("myCol", FieldSpec.DataType.STRING).setPrimaryKeyColumns(Lists.newArrayList("myCol"))
.build();
_tableConfig =
new TableConfigBuilder(TableType.REALTIME).setTableName(RAW_TABLE_NAME).setUpsertConfig(upsertConfig).build();
TableUpsertMetadataManager tableUpsertMetadataManager =
TableUpsertMetadataManagerFactory.create(_tableConfig, null);
assertNotNull(tableUpsertMetadataManager);

// Preloading is not enabled even if enablePreload and enableSnapshot flags are true, as no threads for preloading.
TableDataManager tableDataManager = mock(TableDataManager.class);
when(tableDataManager.getTableDataDir()).thenReturn(new File(RAW_TABLE_NAME));
when(tableDataManager.getSegmentPreloadExecutor()).thenReturn(null);
tableUpsertMetadataManager.init(_tableConfig, schema, tableDataManager);
assertFalse(tableUpsertMetadataManager.isEnablePreload());

// Preloading is enabled if there are threads for preloading and enablePreload and enableSnapshot flags are true.
tableDataManager = mock(TableDataManager.class);
when(tableDataManager.getTableDataDir()).thenReturn(new File(RAW_TABLE_NAME));
when(tableDataManager.getSegmentPreloadExecutor()).thenReturn(mock(ExecutorService.class));
for (boolean[] flags : new boolean[][]{
{true, false}, {false, true}, {false, false}, {true, true}
}) {
upsertConfig.setEnableSnapshot(flags[0]);
upsertConfig.setEnablePreload(flags[1]);
_tableConfig =
new TableConfigBuilder(TableType.REALTIME).setTableName(RAW_TABLE_NAME).setUpsertConfig(upsertConfig).build();
tableUpsertMetadataManager = TableUpsertMetadataManagerFactory.create(_tableConfig, null);
tableUpsertMetadataManager.init(_tableConfig, schema, tableDataManager);
assertEquals(tableUpsertMetadataManager.isEnablePreload(), flags[0] && flags[1],
String.format("enableSnapshot: %b, enablePreload: %b", flags[0], flags[1]));
}
}
}