Part-4: Remove Unnecessary TimeSeries Materialization + Minor Cleanups #14092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really need to build the TimeSeriesBuilders until we return from the LeafTimeSeriesOperator, since there are no time-series related operations under and including the TimeSeriesCombineOperator.
This PR changes the TimeSeriesResultsBlock so that instead of keeping a TimeSeriesBlock, it keeps a new TimeSeriesBuilderBlock, which keeps the un-built series in a map keyed by the series id.
This also enables queries with complex aggregations like Percentile, Rate, etc. (until we support Exchange/Shuffles).
Additionally:
ScanFilterAndProjectNode
to the more appropriateLeafTimeSeriesPlanNode
, since that node technically also corresponds to an aggregation.