Add Docker images SNAPSHOT on Docker HUB (nightly) #1593
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
requested review from
adutra,
ashvina,
dennishuo,
dimas-b,
eric-maynard,
jackye1995,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
MonkeyCanCode,
flyrain,
ebyhr,
HonahX and
singhpk234
as code owners
adutra
reviewed
May 15, 2025
There was a problem hiding this comment.
@jbonofre thanks for driving this, it will be very useful!
Global suggestion: I would change the image names and tags in order to not mix up release images with nightly images:
- name: Build Server Docker image
run: |
./gradlew \
:polaris-quarkus-server:assemble \
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true \
-Dquarkus.container-image.push=true \
-Dquarkus.container-image.name=polaris-nightly \
-Dquarkus.container-image.tag=$(date +%Y%m%d) \
-Dquarkus.container-image.additional-tags=""
- name: Build Admin Tool Docker image
run: |
./gradlew \
:polaris-quarkus-admin:assemble \
:polaris-quarkus-admin:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true \
-Dquarkus.container-image.push=true \
-Dquarkus.container-image.name=polaris-admin-tool-nightly \
-Dquarkus.container-image.tag=$(date +%Y%m%d) \
-Dquarkus.container-image.additional-tags=""| :polaris-quarkus-server:quarkusAppPartsBuild --rerun \ | ||
| :polaris-quarkus-admin:assemble \ | ||
| :polaris-quarkus-admin:quarkusAppPartsBuild --rerun \ | ||
| -Dquarkus.container-image.build=true \ |
| -Dquarkus.container-image.build=true \ | ||
| - name: Push Docker images to Docker HUB | ||
| run: | | ||
| docker push apache/polaris |
There was a problem hiding this comment.
This is only pushing the server image, not the admin tool image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, this PR extends nightly build to push SNAPSHOT images on Docker HUB.