-
Notifications
You must be signed in to change notification settings - Fork 265
main: Update plugin openapi-generator to v7.13.0 #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
main: Update plugin openapi-generator to v7.13.0 #1796
Conversation
Why is this closed? I think, we should make it work, not ignore the bump. |
We’re standardizing on 7.11 elsewhere such as the Python client, and it
became pretty clear during that work that continuing to bump the generator
is likely to introduce breaking changes without much apparent value. If you
see value in bumping a particular dependency, you can always open a PR to do so.
…On Fri, Jun 13, 2025 at 11:53 AM Robert Stupp ***@***.***> wrote:
*snazy* left a comment (apache/polaris#1796)
<#1796 (comment)>
Why is this closed?
What's the reason?
I think, we should make it work, not ignore the bump.
—
Reply to this email directly, view it on GitHub
<#1796 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFRE3SFV5GMNNSUHHLWDO7T3DMM4NAVCNFSM6AAAAAB6PENO3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZRGMZDMNBYGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
As far as Polaris is concerned, I believe this needs a dev email discussion (I might have missed it if it happened, but I do not recall this discussion). |
Yea - I am not aware of such a decision in the Apache Polaris project. Do you have a reference? |
I'm confused what the issue is here. Nothing is stopping anybody from updating a dependency, but how long should we keep an automated PR that's failing CI and creating divergence in the generator used by different parts of the repo open? It was already some two weeks old when I closed it. Is there a reference to some point in time where there was agreement to always keep this dependency up to date? To keep these PRs open indefinitely? |
We cannot upgrade to 7.13 due to this issue, #1822. |
@eric-maynard : from my POV the issue is merely the word "standardizing", which you had in an earlier comment. If we're standardizing on anything, I think that needs a dev email discussion. GH comments are not visible enough for that purpose, IMHO. |
Hi guys, I would like to bring more context here. The issue with the open-api-generator for python client, as documented here: #1822, makes it necessary to use version If open-api-generator community releases a newer version that fix all the compatibility issues, we will be unblocked from upgrading the generator used for python client. So overall it is mainly the breaking changes/technical issues that preventing us from upgrading. I think we could have issue/PRs to track the breaking changes in new dependency versions. IMHO, closing this auto-generated PR will help clarify that we need a manual fix for this version bump. |
Hey Dmitri, apologies if that wording was not the best. That standardization is happening in code. For example, I would say that we have standardized on using the name In the case of the generator, I only meant that we've recently upgraded to 7.11 for the Python client but weren't able to upgrade further at that point in time. Jonas's comment has some details on this. We may be pinned on 7.11 for a while, and I saw that there could be value in aligning this with the rest of the project. If we want to use different versions of the generator for different parts of the code that's totally fine. However when I saw this PR that was:
I closed it to cut down on the number of open PRs, figuring that we'd reopen it if a good reason to do the upgrade arose at some point down the road. Sorry for any confusion. |
Thanks for the background, @flyrain @eric-maynard @HonahX ! What is still unclear from my POV is that this PR changes only My reading is that we already have isolation of I do not have any objections to keeping the python side on an older version of the generator until technical roadblocks are removed. I wonder, though, if we could upgrade the java side independently 🤔 WDYT? |
If the upgrade is problematic - no objections from my side to closing this PR :) |
+1, if this PR can be made to work and the general sentiment is we want to keep upgrading this on the Java side even if Python is pinned, let's fix it up and keep it open. |
b5e5b58
to
6cf9c58
Compare
rebased manually... IDK why Renovate would not rebase this PR 🤷 |
CI failures in java code look non-trivial to me. I think upgrading the API generator even for java code will require some manual work... not sure if there are any volunteers ATM 🤔 |
This PR contains the following updates:
7.12.0
->7.13.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.