-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pagination for list APIs #273
Open
eric-maynard
wants to merge
34
commits into
apache:main
Choose a base branch
from
eric-maynard:pagination
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,507
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau and
jackye1995
as code owners
September 6, 2024 21:27
dbosco
reviewed
Sep 9, 2024
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
dbosco
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't resolve my own feedback. Can you close them? Thanks
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
polaris-core/src/main/java/org/apache/polaris/core/catalog/PageToken.java
Outdated
Show resolved
Hide resolved
eric-maynard
force-pushed
the
pagination
branch
from
September 10, 2024 03:18
850baf4
to
549c5ab
Compare
@eric-maynard let me know if you need any further help on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Apache Iceberg REST catalog spec describes how APIs like
listNamespaces
can implement pagination, but Polaris currently does not implement pagination.This PR implements pagination for
listNamespaces
,listViews
, andlistTables
. It also introduces a framework that could be used to implement pagination for other APIs likelistCatalogs
.Fixes #147
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added tests in
BasePolarisCatalogTest
.Manual testing confirms that the
page-size
limit applies, and that page tokens can be used to continue a listing operation:Checklist:
Please delete options that are not relevant.