Fix 403 error message hints #437
Open
+40
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew4699
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike,
ebyhr and
adutra
as code owners
eric-maynard
reviewed
Nov 7, 2024
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java
Show resolved
Hide resolved
eric-maynard
reviewed
Nov 7, 2024
polaris-service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java
Show resolved
Hide resolved
eric-maynard
reviewed
Nov 7, 2024
polaris-service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java
Outdated
Show resolved
Hide resolved
eric-maynard
approved these changes
Nov 7, 2024
eric-maynard
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a previous change I took a stab at transforming some cloud-provider-specific 403s into Polaris 403s. I don't think the hints were fully accurate as I'm seeing AWS errors that don't mention "access denied". Rather than trying to chase down the exact error messages per cloud provider, I went with reasonable catch-alls. We still only apply this to cloud-provider-specific exception types such as S3Exception so this should be fine.
Type of change
How Has This Been Tested?
Checklist: