[fix][broker] Ensure LoadSheddingTask is scheduled after metadata service is available again #24838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
requested review from
BewareMyPower,
Technoboy-,
codelipenghui,
coderzc,
congbobo184,
gaoran10,
lhotari and
mattisonchao
Demogorgon314
added
area/broker
doc-not-needed
codelipenghui
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After PR: #23040, if the metadata service is unavailable and then becomes available again, the LoadSheddingTask will not run again.
Modifications
Ensure
LoadSheddingTaskis scheduled after metadata service is available again by moving theisMetadataServiceAvailablecheck to the try block.Documentation
docdoc-requireddoc-not-neededdoc-complete