Skip to content

RANGER-4993 : Ranger KMS - Missing HSTS Headers for 404 Not found requests port 9494 #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

dhavalshah9131
Copy link
Contributor

What changes were proposed in this pull request?

RANGER-4993 : Ranger KMS - Missing HSTS Headers for 404 Not found requests port 9494

HSTS header is missing for 404 Not found requests .

E.G.
curl -ivk -u keyadmin:Admin123 https://:9494/

OR

curl -ivk --negotiate -u : https://:9494

< HTTP/1.1 404 Not Found
HTTP/1.1 404 Not Found
< Content-Type: text/html;charset=utf-8
Content-Type: text/html;charset=utf-8
< Content-Language: en
Content-Language: en
< Content-Length: 682
Content-Length: 682
< Date: Mon, 26 Aug 2024 13:12:21 GMT
Date: Mon, 26 Aug 2024 13:12:21 GMT
< Server: Apache Ranger
Server: Apache Ranger

How was this patch tested?

Successfully validated the HSTS header for above API and all the existing APIs such as GET keys, create keys, rollover keys , delete keys.

@dhavalshah9131 dhavalshah9131 requested a review from vikaskr22 June 27, 2025 09:25
Copy link
Contributor

@vikaskr22 vikaskr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added few minor review comments, other things look good to me.

@dhavalshah9131 dhavalshah9131 requested a review from vikaskr22 July 18, 2025 09:21
Copy link
Contributor

@vikaskr22 vikaskr22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@dhavalshah9131 dhavalshah9131 merged commit 1bbcd7e into master Jul 18, 2025
8 of 9 checks passed
kumaab pushed a commit that referenced this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants