RANGER-5246: Add workflow to build multi-platform ranger images and push to DockerHub and GitHub Container Registry #613
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adoroszlai, Could you please review as well, thanks. |
adoroszlai
reviewed
Jul 21, 2025
Comment on lines
136
to
135
| response=$(curl https://oauth.apache.org/token\?code\=${{ github.event.inputs.token }}) | ||
| echo "$response" | jq -e . >/dev/null 2>&1 |
There was a problem hiding this comment.
curlwill output download progress to std.out,jqwill fail to parse it. Use-LSs- Token shown in log in plain text.
Comment on lines
57
to
58
| cp ranger-*-admin.tar.gz dev-support/ranger-docker/dist | ||
| cp version dev-support/ranger-docker/dist |
There was a problem hiding this comment.
Why not mv, is the original file used later?
| runs-on: ubuntu-latest | ||
| env: | ||
| DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }} | ||
| IMAGE_ID: ${{ needs.build.outputs.image-id }} |
There was a problem hiding this comment.
build job should define this output to allow tag to use it, something like:
Also, image-id will contain only ranger image, the other 3 images will not be tagged by this job.
BTW, in the long run, we should avoid building these 3 additional images.
zookeeperimage can be used directly.postgresandsolrimages can also be used, with Ranger-specific files (and password for Postgres) provided by users at runtime (in Docker Compose service definition).
In addition to simplifying the workflow, this would also avoid the problem of hard-coded password in the DB image (which makes it unusable for "production").
…ush to ghcr.io and DockerHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A new workflow to build ranger images:
ranger, ranger-db, ranger-solr and ranger-zkwith multi-arch support and publish them to GitHub Container Registry and optionally to DockerHub.manuallyby providingbranch nameandOAuth tokenOAuth Tokenis generated after successful authentication against ASF OAuth, more details here: https://idm.apache.org/api.htmlHow was this patch tested?
CI Run with successful build stage: https://github.com/kumaab/ranger/actions/runs/16375834642