This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
[REEF-362] Implement a Wake Transport using HTTP #1341
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.reef.wake.remote.transport.netty; | ||
|
|
||
| import io.netty.channel.ChannelFuture; | ||
| import io.netty.channel.ChannelFutureListener; | ||
| import org.apache.reef.wake.remote.transport.LinkListener; | ||
|
|
||
| /** | ||
| * Future Listener used in NettyLink. | ||
| */ | ||
| public final class NettyChannelFutureListener<T> implements ChannelFutureListener { | ||
|
|
||
| private final T message; | ||
| private final LinkListener<T> listener; | ||
|
|
||
| NettyChannelFutureListener(final T message, final LinkListener<T> listener) { | ||
| this.message = message; | ||
| this.listener = listener; | ||
| } | ||
|
|
||
| @Override | ||
| public void operationComplete(final ChannelFuture channelFuture) throws Exception { | ||
| if (channelFuture.isSuccess()) { | ||
| listener.onSuccess(message); | ||
| } else { | ||
| listener.onException(channelFuture.cause(), channelFuture.channel().remoteAddress(), message); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.reef.wake.remote.transport.netty; | ||
|
|
||
| import io.netty.channel.Channel; | ||
| import org.apache.reef.wake.remote.Encoder; | ||
| import org.apache.reef.wake.remote.transport.Link; | ||
| import org.apache.reef.wake.remote.transport.LinkListener; | ||
|
|
||
| /** | ||
| * Factory that creates a NettyLink. | ||
| */ | ||
| public final class NettyDefaultLinkFactory<T> implements NettyLinkFactory { | ||
|
There was a problem hiding this comment. Why don't you create HttpLinkFactory? There was a problem hiding this comment. I've created NettyHttpLinkFactory. Thank you! |
||
|
|
||
| NettyDefaultLinkFactory() {} | ||
|
|
||
| @Override | ||
| public Link newInstance(final Channel channel, final Encoder encoder) { | ||
| return new NettyLink<T>(channel, encoder); | ||
| } | ||
|
|
||
| @Override | ||
| public Link newInstance(final Channel channel, | ||
| final Encoder encoder, | ||
| final LinkListener listener) { | ||
| return new NettyLink<T>(channel, encoder, listener); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.reef.wake.remote.transport.netty; | ||
|
|
||
| import io.netty.buffer.ByteBuf; | ||
| import io.netty.channel.Channel; | ||
| import io.netty.channel.ChannelHandlerContext; | ||
| import io.netty.handler.codec.http.FullHttpResponse; | ||
| import io.netty.handler.codec.http.HttpContent; | ||
| import io.netty.util.CharsetUtil; | ||
| import org.apache.reef.wake.EStage; | ||
| import org.apache.reef.wake.remote.impl.TransportEvent; | ||
|
|
||
| import java.net.SocketAddress; | ||
| import java.util.concurrent.ConcurrentMap; | ||
| import java.util.logging.Level; | ||
| import java.util.logging.Logger; | ||
|
|
||
| /** | ||
| * A Netty event listener for client. | ||
| */ | ||
| final class NettyHttpClientEventListener extends AbstractNettyEventListener { | ||
|
|
||
| private static final Logger LOG = Logger.getLogger(NettyHttpClientEventListener.class.getName()); | ||
| private final StringBuilder buf = new StringBuilder(); | ||
|
|
||
| NettyHttpClientEventListener( | ||
| final ConcurrentMap<SocketAddress, LinkReference> addrToLinkRefMap, | ||
| final EStage<TransportEvent> stage) { | ||
| super(addrToLinkRefMap, stage); | ||
| } | ||
|
|
||
| @Override | ||
| public void channelRead(final ChannelHandlerContext ctx, final Object msg) { | ||
|
There was a problem hiding this comment. How about the following code? public void channelRead(final ChannelHandlerContext ctx, final FullHttpResponse response) {
byte[] content = null;
ByteBuf byteBuf = response.content();
if (byteBuf.hasArray()) {
content = byteBuf.array();
} else {
content = new byte[byteBuf.readableBytes()];
byteBuf.readBytes(content);
}
....
}There was a problem hiding this comment. I'm sorry that as method channelRead is overriding method, I cannot change type of parameter. |
||
| if (msg instanceof FullHttpResponse) { | ||
| if(LOG.isLoggable(Level.FINEST)) { | ||
| LOG.log(Level.FINEST, "HttpResponse Received: {0}", msg); | ||
| } | ||
| final HttpContent httpContent = (HttpContent) msg; | ||
| final ByteBuf content = httpContent.content(); | ||
|
There was a problem hiding this comment. This variable is only used when it is There was a problem hiding this comment. We can just get |
||
| final Channel channel = ctx.channel(); | ||
| final byte[] message = new byte[content.readableBytes()]; | ||
|
|
||
| content.readBytes(message); | ||
| if (LOG.isLoggable(Level.FINEST)) { | ||
| buf.append("CONTENT: ").append(content.toString(CharsetUtil.UTF_8)).append("\r\n"); | ||
|
There was a problem hiding this comment. Why don't you define |
||
| LOG.log(Level.FINEST, "MessageEvent: local: {0} remote: {1} :: {2}", new Object[]{ | ||
| channel.localAddress(), channel.remoteAddress(), buf}); | ||
| buf.setLength(0); // clearing the buffer | ||
| } | ||
|
|
||
| if (message.length > 0) { | ||
| // send to the dispatch stage | ||
| this.stage.onNext(this.getTransportEvent(message, channel)); | ||
| } | ||
| } else { | ||
| LOG.log(Level.SEVERE, "Unknown type of message received: {0}", msg); | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void channelActive(final ChannelHandlerContext ctx) { | ||
| // noop | ||
| } | ||
|
|
||
| @Override | ||
| protected TransportEvent getTransportEvent(final byte[] message, final Channel channel) { | ||
|
There was a problem hiding this comment. I'm not sure why There was a problem hiding this comment. I think this method should not be used outside of netty implementation since the |
||
| return new TransportEvent(message, channel.localAddress(), channel.remoteAddress()); | ||
| } | ||
|
|
||
| @Override | ||
| protected void exceptionCleanup(final ChannelHandlerContext ctx, final Throwable cause) { | ||
|
There was a problem hiding this comment. Replied above. I don't know why It says outdated... |
||
| this.closeChannel(ctx.channel()); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about defining a pipeline variable?
final ChannelPipeline pipeline = ch.pipeline();