Skip to content

Have date chooser dispatch month change events #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

justinmclean
Copy link
Member

Example code:

<js:Application xmlns:fx="http://ns.adobe.com/mxml/2009"
xmlns:js="library://ns.apache.org/royale/basic">

<fx:Script><![CDATA[
    public function monthChange():void {
        trace("month changed");
    }
    ]]></fx:Script>

<js:beads>
    <js:ApplicationDataBinding />
</js:beads>

<js:valuesImpl>
    <js:SimpleCSSValuesImpl/>
</js:valuesImpl>

<js:initialView>
    <js:View>
        <js:Group id="content" height="200" width="250">
            <js:beads>
                <js:VerticalLayout />
            </js:beads>
            <js:DateChooser id="dc1" height="200" monthChanged="monthChange()" />
        </js:Group>
    </js:View>
</js:initialView>

</js:Application>

@justinmclean
Copy link
Member Author

Note as other pull request have not been accepted yet this pull request contains some extra changes and my need to be modified. I can't see any easy way of fixing this as those changes were made in my develop branch.

@pentapache
Copy link
Contributor

I'm looking over the changes. Why does "displayedMonthChanged" need to change to "monthChanged"? I know that adding the [Event] metadata to DateChooser is necessary, but I don't see why the event names had to change. Was there a conflict?

@justinmclean
Copy link
Member Author

justinmclean commented Oct 26, 2017

To make the event handler name more in line with other event handler names. See my email on the dev list can change the event name back if you think it's a better fit.

@Harbs Harbs requested review from aharui and removed request for aharui October 31, 2017 09:00
@justinmclean
Copy link
Member Author

Reopens as PR #100 to remove commit history.

@justinmclean justinmclean deleted the date-chooser-month-change-events branch December 13, 2017 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants