Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][UI] Display data-source information other than password #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qscgu23
Copy link

@qscgu23 qscgu23 commented Oct 13, 2023

Purpose of this pull request

Display data-source information other than password

before

image

after

after

Check list

params: JSON.stringify({
url: row.datasourceConfig.url,
driver: row.datasourceConfig.driver,
user: row.datasourceConfig.user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea to hide password makes sense to me. As datasource configurations can be different for different data source types. can you remove only the password configuration and keeping remaining other configuration as it is, so we will not loose any extra configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants