[Improve] use generate_sink_sql=true for db2 upsert #233
Conversation
|
Please remove [ISSUE-4434] from the PR title. Instead, you can mention the issue reference in the PR description. The PR title can be named as [Improve][DB2]..." |
|
|
||
| connectorConfig = | ||
| connectorConfig.withValue(QUERY_KEY, ConfigValueFactory.fromAnyRef(sql)); | ||
| if (selectTableFields.isAll()) { |
There was a problem hiding this comment.
I do not see any reference of generate_sink_sql change or use. can you explain the code change, how it is related to db2 upsert
| connectorConfig = | ||
| connectorConfig.withValue( | ||
| QUERY_KEY, ConfigValueFactory.fromAnyRef(sql)); | ||
| } |
There was a problem hiding this comment.
can you attach snapshot or test cases for this change
There was a problem hiding this comment.
Done @arshadmohammad!
Thanks for your time, have incorporated the review comments.
shashwatsai
force-pushed
the
feature/ISSUE-4434-db2-upsert-use-generate-sink-sql
branch
from
f8c2baa
to
ca1f460
Compare
shashwatsai
changed the title
shashwatsai
force-pushed
the
feature/ISSUE-4434-db2-upsert-use-generate-sink-sql
branch
from
ca1f460
to
8f43cac
Compare
|
Manual Deployment: Source: Hive JDBC (partitioned table) Sink: DB2 Trigger for row updates: generated job config: Validations: |
|
Thanks @shashwatsai for working on db2 issues. |
Purpose of this pull request
Currently we enforce sending sink insert query, forcing user to not support upsert scenarios.
Please refer:
ISSUE: apache/seatunnel#4434
PR (Upsert DB2 Support): apache/seatunnel#7879
Check list
New License Guide