Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null #4812

Closed
wants to merge 5 commits into from

Conversation

choucmei
Copy link
Contributor

@choucmei choucmei commented May 23, 2023

Purpose of this pull request

Check list

@choucmei
Copy link
Contributor Author

This PR was blocked by e2e because mysql e2e was losing data.
#4732

@EricJoy2048
Copy link
Member

What problem is this PR trying to solve? Do you need to modify the title?

@choucmei choucmei changed the title [Bug] [JDBC Connector] JDBC Source lost data,when the data of partition_column is null. #4732 [Bugfix] [connector-jdbc] Fix when type is int and null value will always get 0 instead of null May 24, 2023
@ic4y ic4y closed this Aug 5, 2023
@ic4y ic4y reopened this Aug 5, 2023
@EricJoy2048 EricJoy2048 reopened this Sep 11, 2023
@EricJoy2048
Copy link
Member

Please fix CI error.

@EricJoy2048
Copy link
Member

LGTM, Should you add e2e test to test this pr?

@choucmei
Copy link
Contributor Author

LGTM, Should you add e2e test to test this pr?

LGTM, Should you add e2e test to test this pr?

I will add e2e testing as soon as possible

@hailin0
Copy link
Member

hailin0 commented Oct 12, 2023

@choucmei
Please check ci error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants