Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][JsonUtils] Use a static object mapper instead of creating it every time #5460

Merged
merged 10 commits into from
Sep 18, 2023

Conversation

Morssssy
Copy link
Contributor

[Improve][JsonUtils] Use a static object mapper instead of creating it every time

Purpose of this pull request

ObjectMapper class consumes a certain amount of system resources during instance creation. Instances of ObjectMapper should be reused.

Check list

[Improve][JsonUtils] Use a static object mapper instead of creating it every time
@ruanwenjun ruanwenjun added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Sep 14, 2023
@ruanwenjun
Copy link
Member

@Morssssy Please solve the code style by mvn spoless:apply

@Morssssy
Copy link
Contributor Author

@Morssssy Please solve the code style by mvn spoless:apply

done

@Hisoka-X Hisoka-X added the First-time contributor First-time contributor label Sep 15, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun
Copy link
Member

Could you please rebase your dev branch with upstream dev.

@liugddx
Copy link
Member

liugddx commented Sep 18, 2023

Please merge the latest dev branch.

@Morssssy
Copy link
Contributor Author

@ruanwenjun @liugddx DONE

@liugddx
Copy link
Member

liugddx commented Sep 18, 2023

@ruanwenjun @liugddx DONE

Please wait for CI to complete.

@EricJoy2048 EricJoy2048 merged commit 38a2f83 into apache:dev Sep 18, 2023
3 checks passed
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. First-time contributor First-time contributor ready to merge reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants