Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2] Support multi-table sink feature for kudu #5951

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

Carl-Zhou-CN
Copy link
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

close #5719

How was this patch tested?

new e2e test

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 4, 2023

Please waiting #5955 be merged, then do test again.
image

@Carl-Zhou-CN
Copy link
Member Author

Please waiting #5955 be merged, then do test again. image

ok

docs/en/connector-v2/sink/Kudu.md Outdated Show resolved Hide resolved
@@ -210,10 +215,6 @@ private void initializeKuduTable() throws KuduException {
new ColumnSchema.ColumnSchemaBuilder("val_unixtime_micros", Type.UNIXTIME_MICROS)
.nullable(true)
.build());
columns.add(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove binary type?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary type, difficult to generate in fake, and difficult to compare,KuduIT contains all types of checks

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 82460c0 into apache:dev Dec 14, 2023
6 checks passed
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2] Support multi-table sink feature for kudu
4 participants