Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-table sink feature for influxdb #6278

Merged
merged 12 commits into from
Feb 27, 2024

Conversation

531651225
Copy link
Contributor

Purpose of this pull request

Support multi-table sink feature for influxdb
refer to #5652

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@531651225
Copy link
Contributor Author

@hailin0 @EricJoy2048 please cc

@hailin0
Copy link
Member

hailin0 commented Jan 25, 2024

please fix ci

@hailin0
Copy link
Member

hailin0 commented Feb 18, 2024

cc @Hisoka-X

@@ -46,7 +56,7 @@ public String factoryIdentifier() {
@Override
public OptionRule optionRule() {
return OptionRule.builder()
.required(URL, DATABASES, KEY_MEASUREMENT)
.required(URL, DATABASES)
.bundled(USERNAME, PASSWORD)
.optional(
CONNECT_TIMEOUT_MS,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CONNECT_TIMEOUT_MS,
CONNECT_TIMEOUT_MS,
KEY_MEASUREMENT,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hisoka-X thinks, I fix it

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 56f13e9 into apache:dev Feb 27, 2024
5 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants