Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][RestAPI] Support submit job with seatunnel style hocon format config #8000

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

CosmosNi
Copy link
Contributor

@CosmosNi CosmosNi commented Nov 8, 2024

#7925

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 8, 2024

cc @liugddx

@Hisoka-X Hisoka-X linked an issue Nov 8, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs. Thanks @CosmosNi !

@liunaijie
Copy link
Member

I see this pr is put the config string to request body.
Do we conside using multipart/form-data upload the file into a config_file (or other name) parameter

@Hisoka-X
Copy link
Member

Do we conside using multipart/form-data upload the file into a config_file (or other name) parameter

Ok for me, but I think this should be another feature. Please create an issue for this.

@liunaijie
Copy link
Member

Do we conside using multipart/form-data upload the file into a config_file (or other name) parameter

Ok for me, but I think this should be another feature. Please create an issue for this.

Yes, it should be in another pr, just point it in this issue.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CosmosNi ! Please update the doc too.

@@ -27,6 +27,8 @@ public class RestConstant {

public static final String IS_STOP_WITH_SAVE_POINT = "isStopWithSavePoint";

public static final String ENV_CONFIG_STYLE = "configStyle";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final String ENV_CONFIG_STYLE = "configStyle";
public static final String ENV_CONFIG_FORMAT = "format";

I think use the format more clear.

@github-actions github-actions bot removed the e2e label Nov 14, 2024
@github-actions github-actions bot added the e2e label Nov 15, 2024
> | jobId | optional | string | job id |
> | jobName | optional | string | job name |
> | isStartWithSavePoint | optional | string | if job is started with save point |
> | format | optional | string | config style,json/hocon,default json |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> | format | optional | string | config style,json/hocon,default json |
> | format | optional | string | config format, support json and hocon, default json |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][RestAPI] Support submit job with seatunnel style hocon format config
4 participants