-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][RestAPI] Support submit job with seatunnel style hocon format config #8000
base: dev
Are you sure you want to change the base?
Conversation
cc @liugddx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docs. Thanks @CosmosNi !
Thanks @CosmosNi ! Can you add a test case for normal submission? like https://github.com/apache/seatunnel/blob/ccd6a2a11e8d8198258301c81d71e8ed306e917a/seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterSeaTunnelContainer.java#L123C17-L123C45 |
I see this pr is put the config string to request body. |
Ok for me, but I think this should be another feature. Please create an issue for this. |
Yes, it should be in another pr, just point it in this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CosmosNi ! Please update the doc too.
@@ -27,6 +27,8 @@ public class RestConstant { | |||
|
|||
public static final String IS_STOP_WITH_SAVE_POINT = "isStopWithSavePoint"; | |||
|
|||
public static final String ENV_CONFIG_STYLE = "configStyle"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static final String ENV_CONFIG_STYLE = "configStyle"; | |
public static final String ENV_CONFIG_FORMAT = "format"; |
I think use the format more clear.
> | jobId | optional | string | job id | | ||
> | jobName | optional | string | job name | | ||
> | isStartWithSavePoint | optional | string | if job is started with save point | | ||
> | format | optional | string | config style,json/hocon,default json | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> | format | optional | string | config style,json/hocon,default json | | |
> | format | optional | string | config format, support json and hocon, default json | |
#7925
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.