Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][POM] Bump the version of maven-shade-plugin to 3.4.1 #8067

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Nov 15, 2024

Purpose of this pull request

I defined a SPI services in paimon connetor.
1

The SPI services with a same filepath in the pom dependency that overwrite the SPI services file. Even though I configured the transformer in the shade plugin.
2

I found this is a bug in the shade plugin, which was fixed in version 3.4.1.

link: https://github.com/apache/maven-shade-plugin/releases/tag/maven-shade-plugin-3.4.1
截屏2024-11-15 14 28 30

When I upgrade the maven-shade plugin, It's all right.

3

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Carl-Zhou-CN Carl-Zhou-CN merged commit 102d9f9 into apache:dev Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants