Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor][core] Unify transformFactory creation logic #8574

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Jan 22, 2025

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the core SeaTunnel core module label Jan 22, 2025
@github-actions github-actions bot added the api label Jan 23, 2025
@liugddx liugddx requested a review from Hisoka-X January 23, 2025 09:26
Hisoka-X
Hisoka-X previously approved these changes Jan 23, 2025
ClassLoader classLoader,
Class<T> factoryClass,
String factoryIdentifier,
Function<String, T> transformFactoryFunction) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why named transformFactoryFunction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api core SeaTunnel core module Zeta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants