[improve] update activemq connector config option #8580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liunaijie
commented
Jan 23, 2025
|
|
||
| private final Map<String, Object> sinkOptionProps = new HashMap<>(); | ||
|
|
||
| public static final Option<String> HOST = |
There was a problem hiding this comment.
Those parameters are defined, but not used. So I delete them.
3 tasks
|
I think we should add a test case to verify the all connector has xxxSinkOptions or xxxSourceOptions. |
Good point, I will write the test. |
akulabs8
reviewed
Jan 27, 2025
| @@ -42,11 +40,6 @@ public void write(SeaTunnelRow element) { | |||
| activeMQClient.write(serializationSchema.serialize(element)); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
why did you remove this entire bit of code for optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
subtask of #8576
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.